Fix concurrent map write crash in logIfChanged #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loggedImages map needs to be synchronized. Fixes submariner-io/submariner#2872 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr2933/tpantelis/logIfChanged_crash |
aswinsuryan
approved these changes
Jan 10, 2024
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Jan 10, 2024
Release notes for submariner-io/submariner-operator#2933 Signed-off-by: Tom Pantelis <[email protected]>
vthapar
approved these changes
Jan 10, 2024
|
🤖 Closed branches: [z_pr2933/tpantelis/logIfChanged_crash] |
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Jan 11, 2024
Release notes for submariner-io/submariner-operator#2933 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Jan 11, 2024
Release notes for submariner-io/submariner-operator#2933 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Jan 11, 2024
Release notes for submariner-io/submariner-operator#2933 Signed-off-by: Tom Pantelis <[email protected]>
aswinsuryan
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Jan 11, 2024
Release notes for submariner-io/submariner-operator#2933 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Jan 15, 2024
Release notes for submariner-io/submariner-operator#2933 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Feb 27, 2024
Release notes for submariner-io/submariner-operator#2933 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Feb 29, 2024
Release notes for submariner-io/submariner-operator#2933 Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
loggedImagesmap needs to be synchronized.Fixes submariner-io/submariner#2872